What I noticed: You keep your input file in memory while you read your abreviations line by line.

Depending on the usual size of those files this might be a good choice.

OTOH: I'd expect an inputfile to be substantially larger than your abreviations.

if so you might want to consider to keep the abreviations in memory and to loop over the input lines:

# UNTESTED! use strict; use warnings; open( ABB, '<', 'jabb.txt' ) or die "Couldn't open ABB.\n$!"; open( IN, '<', 'input.txt' ) or die "Couldn't open infile.\n$!"; open( OUT, '>', 'output.out' ) or die "Couldn't open outfile.\n$!"; # prepare abreviations my %abb; while(<ABB>){ # there are shorter ways to do it, but to keep your code... if(/(.*?)\t(.*?)\n/) { $abb{$2}= $1 } } close ABB; # build a RE for quickly(?) finding abbreviatable words. my $abbre= join('|', map "\Q$_\E",keys %abb); $abbre= qr/\b($abbre)\b/; # replace my @myin = <IN>; while(<IN>){ s/$abbre/$abb{$1}/g; print OUT; } close IN; close OUT;

Update: Thanks to Zaxo's obfu-entry ;-) below I noticed I forgot to escape the list of abbreviatable words.


s$$([},&%#}/&/]+}%&{})*;#$&&s&&$^X.($'^"%]=\&(|?*{%
+.+=%;.#_}\&"^"-+%*).}%:##%}={~=~:.")&e&&s""`$''`"e

In reply to Re: find and replace by Skeeve
in thread find and replace by texuser74

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.