You actually have two problems. First, regexes don't work on arrays directly. Second, a substitution (s///) returns the number of substitutions made. You don't want $term = s/$full/$abb/g, because the = will assign that count to $term. You want =~ which means "make this regex act on" (sort of).

This could be easily fixed by slurping, rather than reading your IN into an array.

# instead of @myin = <IN>; my $myin; { local $/ = undef; $myin = <IN>; #slurp all to scalar } #instead of print "@myin\n"; @myin = s/$full/$abb/g; print "$myin\n"; $myin =~ s/\b$full\b/abb/g
Update:benizi pointed out my foolishness in capturing word boundaries. The sad thing is, I knew that and did it anyway. That's like the fourth really dumb thing I've done today. Sigh. Thanks, benizi!

I took the liberty of capturingmatching word boundaries (\b) and adding them back ($1 and $2), since without that code, you'd replace too much. For example, trying to replace all occurances of 'hello' with 'hi', you'd change 'Othello' into 'Othi'. ;-) Checking for word boundaries should help with that.

<-radiant.matrix->
A collection of thoughts and links from the minds of geeks
The Code that can be seen is not the true Code
"In any sufficiently large group of people, most are idiots" - Kaa's Law

In reply to Re: find and replace by radiantmatrix
in thread find and replace by texuser74

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.