I think in general your approach is probably a better one - especially if there are a significant number of functions that are being proxied. The code you posted seems reasonable to my quick read, and could easily be applied to other wrappers.

However in this particular case I'm actually doing a little bit more in the forwarding-methods (keeping track of cache hits/misses, and verifying that some state is massaged appropriately).

I have updated the code here to work properly under strict + warnings, as you are utterly correct about the broken options hash being invalid.

About your last comment in the method renaming, you are correct. I only changed the names because I'm using a few singletons in my application and every other one uses disconnect - rather than disconnect_all, so it seemed natural to change it to match. On balance leaving its name alone seems best.

++ for the feedback.

Steve
--

In reply to Re^2: A singleton wrapper around Cache::Memcached by skx
in thread A singleton wrapper around Cache::Memcached by skx

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.