I don't think you get how the 'wanted' function works. It is run once for each file and directory in the tree you're searching.

If you don't want a global array to store these results, you have two choices: you can either make the wanted function do the work on each file, or you can change the structure of your program. The former might look like:

sub main { findit(); # dostuff($_) for @dirlist; } sub findit { find(\&wanted, shift(@ARGV)); } sub wanted { return unless -d $_; # push(@dirlist,$File::Find::name); dostuff($File::Find::name); } sub dostuff { print "$_\n" }

I commented out the lines in your code, so you can more easily see the change.

The latter solution might look something like this:

sub main { my @dirlist; find( sub { return unless -d $_; push(@dirlist,$File::Find::name); }, (shift @ARGV) ); dostuff($_) for @dirlist; } sub dostuff { print "$_\n"; }

I highly recommend the first approach -- it seems silly, in most cases, to build a list of files and then act on it when you can act on each file as you find it.

<-radiant.matrix->
A collection of thoughts and links from the minds of geeks
The Code that can be seen is not the true Code
"In any sufficiently large group of people, most are idiots" - Kaa's Law

In reply to Re: Return values, Closure Vars from File::Find &wanted subs? by radiantmatrix
in thread Return values, Closure Vars from File::Find &wanted subs? by Subliminal Kid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.