Hi,
you need to make the old largest number the second_largest if there is a new largest one.
I fixed some other minor things as well.
#!/usr/bin/perl -w use strict; my @input = <DATA>; chomp @input; my $largest_value = 0; my $second_value = 0; for (@input){ #$value = substr($input[$i], 0, 6); why? Perl can dwal with floati +ng point numbers if($_ > $largest_value){ $second_value = $largest_value; $largest_value= $_; } elsif(($_ > $second_value) && ($_ < $largest_value)){ $second_value = $_; } } print "$largest_value $second_value\n"; __DATA__ 0.2430 0.0830 0.1320 0.0920 0.0180 0.0880 0.3440
prints
0.3440 0.2430

Regards,
svenXY

In reply to Re: extracting the largest values by svenXY
in thread extracting the largest values by Angharad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.