I managed to get caught out the other day writing something that amounted to the following code.
#!/usr/bin/perl -w use strict; open (IN, "file1") or die("can't blah blah"); while (<IN>) { print; print slurp(); } sub slurp { my $slurp = do { local $/ = undef; open IN, "file2"; <IN>}; return $slurp; }
Can you spot it? Yeah, of course you can, but my code was a bit more involved than this ;). To clarify, what happens is as follows. The first 'while' successfully reads the first line of file1. It prints this line, then the slurp returns file2, and its contents are also printed. Unfortunately, because I used the same file handle, the while thinks its at the end of file1 and and skips to the end.

Okay fair enough, filehandles appear to be global, my stupid mistake, but my question is this...

Can I avoid ever making this mistake again?

Should I always 'use FileHandle'? Is this a bit over the top, or worth the effort? It would have been nice if I'd been given some warning too. :)

I'd be interested to hear if others have been caught out by this, and what you're doing now to avoid the same.

---
my name's not Keith, and I'm not reasonable.

In reply to Filehandles, scope and warnings. by reasonablekeith

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.