Apart from using 'my', there seem to be other good habits to get into from reading the OP:

- using close,

- avoiding unecessary loops that repeat the same functionality - for example the OP code opens and reopens the same file and slurps it for each line of another file.

- if the container for the filehandle goes out of scope inconveniently, just transfer it to one that does have adequate scope.

Or to put that all into code:

#!/usr/bin/perl 
use strict;
use warnings;
open my $fh1, "file1" or die "$!: file1";
my $fh2;
my @file2;
{ local $/ = undef;
  open my $fh, "file2" or die "$!: file2";
  $fh2 = $fh;
  @file2 = <$fh>;
}
close $fh2; # could have closed in the above block, but just illustrat
+ing a point about scope here
while (<$fh1>) {
    print;
    print @file2;
}
close $fh1;

[download]

-M

Free your mind

In reply to Re: Filehandles, scope and warnings. by Moron
in thread Filehandles, scope and warnings. by reasonablekeith

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.