The error is pointed out above, but I would like to suggest that you use lexical variables instead of magic file handles. In perl 5.6 or later, instead of using barewords like FILE you can use variables like this:

use strict;

my $output_file_name = "ConsumerMV.sh";
my $input_file_name = "mikels.out";

my $output_file_handle;
my $input_file_handle;

open( $input_file_handle, $input_file_name) or
    die "Unable to open input file '$input_file_name' : $!";

open( $output_file_handle, $output_file_name) or
    die "Unable to open output file '$output_file_name' : $!";

while (<$input_file_handle>) {
     do_stuff;
}
close $input_file;
close $output_file;

[download]
IMHO this is a much cleaner way to handle file handles. It also often protects you from leaving file handles lying around. If the code above was in a sub definition (or any other block like an if () {}) the file handles would automatically be closed by perl as soon as the variables fell out of scope at the end of the block - even if you forgot to call close.

In reply to Re: FILE READ and WRITE by aufflick
in thread FILE READ and WRITE by mbayer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.