Beside a memory leak, there's the possibility of a subtle bug. I had to modify your code slightly, but consider the following class: 
use strict;
use warnings;

package Class::SomeMethodMaker;

sub create_accessor {
    my %hash = ();
    return sub {
        my ($self, $value) = @_;
        $hash{$self} = $value if @_ > 1;
        return $hash{$self};
    }
}


package MyClass;


{ no strict 'refs';
  *{"MyClass::colour"} = Class::SomeMethodMaker::create_accessor;
}

sub new {bless {}, shift}

1;

__END__

[download]
It's a simple class with a single accessor.

Now I use this class in the following way: 

use strict;
use warnings;
use MyClass;

for my $colour (qw /green yellow/) {
    my $obj = MyClass->new;
    $obj->colour($colour) unless $obj->colour;
    print $obj->colour, "\n";
}

__END__

[download]
You would expect it to print green\nyellow\n. However, it prints green\ngreen\n. The problem is that references are unique - but only references that exist at the same moment in time. References are not necessarely unique over time - they may be reused. Your technique only works if you do some work at DESTROY time - and that makes it trickier.
Perl --((8:>*

In reply to Re^5: A Class:: module I don't want to write by Perl Mouse
in thread A Class:: module I don't want to write by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.