A couple of general comments for your enlightenment.
- When posting code, delete the stuff that's commented out.
- Look up 'heredocs' for chunks of text that flow over multiple lines.
- Whenever you find yourself repeating code, think about how it could be made into a loop.
- On a grander scale, think about how you could have modelled a BINGO card (of which, more later).
- There's a reason good code is indented regularly -- it makes it more readable. Your code is not particularly readable, partially because it's not regularly indented
Modelling a BINGO card
Well. A BINGO card is basically five columns with B-I-N-G-O across the top, and columns of numbers, choose five randomly from 1-15 under B, and so forth to 61-75 under O.
Once you know that, lots of the code you've got here can be vastly simplified. You could call a module to set the values of each card, then print out the artwork for each card. The main line program would be a dozen lines long.
Anyway, good work posting this code -- read all of the replies carefully, you should learn a great deal, as I have for the four years that I've been here. Good luck.
Alex / talexb / Toronto
"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.