You print once for every pass of the inner loop (4*2 times), but you only want to print once for every pass of the outer loop (4 times). Fix:
foreach my $adv79key (keys %adv79) {
my $old;
foreach my $exerrors (@exerrors) {
if ($adv79key == $exerrors) {
$old = 1;
last; # shortcut.
}
}
if ($old) {
print "$adv79key is an old error\n";
} else {
print "$adv79key is a new error\n";
}
}
Simplified (but removes shortcut):
foreach my $adv79key (keys %adv79) {
if ( grep { $adv79key == $_ } @exerrors ) {
print "$adv79key is an old error\n";
} else {
print "$adv79key is a new error\n";
}
}
Optimized for speed:
my %exerrors = map { 0+$_ => 1 } @exerrors;
foreach my $adv79key (keys %adv79) {
if ( $exerrors{0+$adv79key} ) {
print "$adv79key is an old error\n";
} else {
print "$adv79key is a new error\n";
}
}
The "0+"s are probably optional. Just trying to be as close to the original as possible.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.