You are looping 8 times. You are printing it is new error before you check all possible elements. I have modified your code to fix this issue. Second part of the code is using a hash. It is much better way to check if elements are present. 

#!/usr/bin/perl

use strict;
use warnings;

my @exerrors = (123,456);
my %adv79    = (123=>1,456=>1,789=>1,777=>1);
my $flag = 0;

foreach my $adv79key (keys %adv79) {
    $flag = 0;
    foreach my $exerrors (@exerrors) {
        if ($adv79key == $exerrors) {
            print "$adv79key is an old error\n";
            $flag = 1;
            last;

        }
    }
    print "$adv79key is a new error\n" if (0 == $flag);
}

print $/;

my %newerr   = map {$_ => 1} @exerrors;

foreach my $adv79key (keys %adv79) {
    if (exists($newerr{$adv79key})) {
        print "$adv79key is an old error\n";
    } else {
        print "$adv79key is an new error\n";
    }
}

[download]

Output

456 is an old error
123 is an old error
789 is a new error
777 is a new error

456 is an old error
123 is an old error
789 is an new error
777 is an new error

[download]

update: fixed typo

In reply to Re: problem with foreach statement by sk
in thread problem with foreach statement by ultibuzz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.