In principle, that is the approach, but I’d execute it a little differently since we’re not writing Pascal:

my ( $digits, $letter ) = $input =~ m{ ^ (\d{7}) ([A-Z]) $ }x; if( not defined $digits ) { print "Invalid input: $input\n"; return; # or last, or exit, depending on what sort of block we're in } # rest of code such as split //, $digits follows here

That avoids imposing another level of indentation upon the code in the normal flow of execution, and it keeps the condition check and its error handling close together.

Makeshifts last the longest.


In reply to Re^3: A better way than || by Aristotle
in thread A better way than || by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.