I know it's not a big issue, but personally i don't like to put variables captured in between quotes like this:
my $message = "<event id=\"ALERT_$tier_$code1\" source=\"APP\">";
I do think it's better maintainable, readable etc. if you concatenate strings like this:
my $message = "<event id=\"ALERT_" . $tier . "_" . $code1 . "\" source=\"APP\">";
As you immediately see in the last line, the $tier and $code1 are Perl variables, as you don't see that as fast in your given one.

update: or indeed use grandfather's ${tier}

update2: I have to agree to davidrw, sprintf works even more clean. I have to admit as well, that i don't use it that often, even though it's a great function for string formatting, and i really don't know why.
Perhaps i need to force myself a bit more :).

"We all agree on the necessity of compromise. We just can't agree on when it's necessary to compromise." - Larry Wall.

In reply to Re: the variable is not getting assigned by jbrugger
in thread the variable is not getting assigned by s_gaurav1091

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.