Well, that’s a very clumsy data structure you have there. And the code is clumsier than it needs to be, on top of that. What’s that count doing? Looks like a no-op to me. And don’t use for(;;), use for(@LIST):

for my $i ( 0 .. $#{ $self->{ keys } } ) {
    my $id = $self->{ keys }->[ $i ];
    # ...
}

[download]

You could write accessor methods for that part of the data structure so you could say something like:

for my $i ( 0 .. $self->max_index() ) {
    my ( $key, $value ) = $self->at( $i );
    # ...
}

[download]

Or maybe an iterator would be better?

my $iter = $self->iterator();

while( my ( $key, $value ) = $iter->() ) {
    # ...
}

[download]

Or you could use one of the modules that implement ordered hashes, such as Tie::IxHash, which will let you write this directly using keys and friends.

Lots of options that depend on what you want to do; for laziness, the tied hash is hard to beat.

Makeshifts last the longest.

In reply to Re: "array" search by Aristotle
in thread "array" search by Sheol

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.