I'd recommend doing code reviews more often than monthly. If you do them monthly you really have to review everything that has been produced in a month in one go, which will take a long time. Long tasks which require lots of concentration tend to be done quite sloppily cos people get tired. And you have to review everything in one go, cos if not it could be many months between something being written and reviewed.

Better in my opinion to have weekly reviews, where one particular chunk of functionality is reviewed. In a team of four or five developers, this means that everyone has their code reviewed roughly monthly, and doing it so regularly makes it easier to get into the habit of doing them.

Not sure how to cope with resistance from the team. Frankly, people who aren't willing to have their code reviewed are people I wouldn't want to work with anyway. Cos if they don't want their code reviewed, presumably they don't want anyone else to maintain their code either, which is just stupid.

When I wrote our code review guidelines, I made it clear that code review is not meant to be competitive; it's not about finding fault with each other. It's about learning good techniques from each other and about helping each other. Perhaps you can break the ice by volunteering to be the first one have your code go under the microscope.

In reply to Re^4: Programming Department by DrHyde
in thread Programming Department by danambroseUK

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.