It works, but it’s surprising. I had to blink and stare for a moment before I noticed that it actually does do what you intended. All in all, considering the other things I mentioned, I’d write the loop like this:

while ( <INFILE> ) {
    next if not /ver = '(.*?)'/;
    $old_version = $1;
    close INFILE;
    last;
}

[download]

Better yet, if you just opened the file:

{
    open my $fh, '<', $filename
        or die "Can't open $filename: $!\n";

    while ( <$fh> ) {
        next if not /ver = '(.*?)'/;
        $old_version = $1;
        last;
    }
}

[download]

In which case $fh goes out of scope at the end of the block and the file is closed automatically; much nicer. I only explicitly close files that I write to (because they you want to check the return value of close, which may fail for such reasons as “disk full” or the like).

In fact, if the file is so small that you don’t mind slurping it, you could just say

use List::Util qw( first );

my $old_version = do {
    open my $fh, '<', $filename
        or die "Can't open $filename: $!\n";

    first { /ver = '(.*?)'/ } <$fh>;
};

[download]

Makeshifts last the longest.

In reply to Re^3: reading values from file by Aristotle
in thread reading values from file by perlNinny

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.