As a start, you could change your module like this: 

package Mine::Openview::opcmsg;

use strict;
use warnings;

sub new {
    my $class = shift;
    my %params = @_;
    my $self  = \%params;
    return bless $self, $class;
}

sub send {
  my $self = shift;
# Setup arguments for opcmsg command.  If the syntax 
# changes this is were you'll apply the changes.
    my $cmd = "opcmsg". 
        " msg_text=".$self->{cmd}.
        " application=".$self{app}.
        " object=".$self->{obj}.
        " severity=".$self->{sev}.
        " msg_grp=".$self->{msgg}.
        " service_id=".$self->{ser};

    return $cmd;
}

1;

[download]

That would allow you to access the module variables like this: 

..in module..
sub somefunction
{
   my $self = shift;
   my $msg = $self->{msg};
}

[download]

I.e. it makes the hash %params which contains your parameters the basis for the object you're creating - it then contains all the values you've passed to the constructor.

--------------------------------------------------------------

"If there is such a phenomenon as absolute evil, it consists in treating another human being as a thing."

John Brunner, "The Shockwave Rider".

In reply to Re: Help with building modules by g0n
in thread Help with building modules by neilwatson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.