I have code like this that is repeated over and over again in the same script. 
my @list_var;
if (ref $giant_hash{key} eq 'ARRAY') {
    for (@{ $giant_hash{key} }) {
        push @list_var, My::Class::Child->new( $_ );
    }
} else {
    push @list_var, My::Class::Child->new( $giant_hash{key} );
}

[download]
I'm trying to refactor it into one subroutine. The only thing that changes is the @list_var and the My::Class::Child.

I did this: 

our %giant_hash = Module->whatever();

sub _fill_lists {
    my ($thing, $thing_ref) = @_;

    my ($method , $flag);
    SWITCH: for ($thing) {
        /XXX/ && do {
            $method = \&My::Class::XXX->new;
            last;
        };
        /YYY/ && do {
            $method = \&My::Class::YYY->new;
            last;
        };
        /etc/    && do {$and_so_on; last; };
    }

    if (ref $giant_hash{$thing} eq 'ARRAY') {
        for (@{ $giant_hash{$thing} }) {
            push @{ $thing_ref }, $method->( $_ );
        }
    } else {
        push @{ $thing_ref }, $method->( $giant_hash{$thing} );
    }

}

[download]
But I'm getting a reference violation error that I can't quite understand why. 
Can't use string ("XXX") as an ARRAY ref while "strict refs" in use at
+ ./testme.pl line 76.

[download]
Nor am I feeling inspired right about now with a decent solution.

Any ideas?

In reply to Need Help Refactoring Method Calls by jffry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.