In my experience code review is only a valid experience under one of two catagories.

• The review refers to a defacto standard that has not been adhered to
• The review offers at least basic reasoning behind a decision.

Neither apears to have occured in this case.

There are very few central core truths to programming. The rest are interpritation and implimentation, specifically of the core truthes. In my experience:

• code should be as simple as it needs to be be and no more so.
• code should be as efficient as it needs to be and no more so.
• code should be as readable as it needs to be and no more so.
• code should be as reliable as it needs to and no more so.
• code should fulfil its technical design brief.

In my opinion all coding standards come from these. The question I would be asking is not what do other people do, because other people often know no better than you (or I) I would ask what core principle does 'not using shift' fulfil. Does it make code faster, simpler, more reliable? However as all decisions are a trade off I would ask myself do I need whatever advantage and can I accept the disadvantages that it would also bring.

On balance looking at the list I have given above to shift or not to shift. It dont matter one wit, tiss simply a matter of style, style being something that too frequenly is mixed up with a coding standard. Where do those brackets go again?
--

Zigster

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.