I'm no expert on XS files either, which is why I usually let Inline::C handle that side of things ... but I don't think 'data' should be safefree()'d ... and I wish you had pointed it out sooner :-)
I got sidetracked into thinking that there must be something bodgey in the way the GD::Image objects were being created.
You could probably go a little further and not even declare and assign a value to 'data'. I think one could just as well write
RETVAL = (GD__Image) gdImageCreateFromGdPtr(len,(void*)SvPV(imageData,
+ len));
but that's only a minor point.
It's unclear to me how 'len' gets assigned the appropriate value for when it's needed ... but it seems to happen ok.
You should probably go to
http://rt.cpan.org/Public/Dist/Display.html?Name=GD and report the bug there - or at least let the author know.
Well spotted !!
Cheers,
Rob
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.