Second question today, please nobody shoot me!
I have a subroutine that fetches a URL and saves it to the named file.
I use LWP::UserAgent and HTTP::Request. As you can see from the code, the
subroutine tries three times to fetch the URL (sleeping for 5 seconds between fetches)
and if all three fail, returns 0. (Leaving the caller to handle appropriately).
My question though is: Is there a better way to do this?
use strict;
use LWP::UserAgent;
#################################################################
# Returns the success of storing $url into newly created $output
sub get_page {
my( $url, $output ) = @_;
my $ua = LWP::UserAgent->new;
$ua->agent( "$0/0.5 " . $ua->agent);
$ua->timeout( 30 );
my $req = HTTP::Request->new( GET => $url );
$req->header( 'Accept' => 'text/html, image/gif' );
for( my $i = 1; $i <= 3; $i++ ) {
# Send the request
my $res = $ua->request( $req );
if( $res->is_success ) {
open( OUT, ">$output" ) or
die "Couldn't open $output: $!";
print OUT $res->content;
close( OUT ) or die "Couldn't close $output: $!";
return 1;
} else {
print "Couldn't get $url on $i/3\n";
print "Sleeping 5 seconds...\n";
sleep 5;
print "Gonna try again...\n";
}
}
return 0;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.