What do you Monks think?

It depends :-)

It it were me I would have started off with a test for addToAccount() before I wrote any code - since that's the public API. Maybe something like (guessing at the rest of the API):

my $account = Account->new;
$account->addToAccount( 10 );
is( $account->getCreditAmount, 10, 'added ten' );

[download]

And gone ahead and written the code. I might then have spotted that the &{$closure}( "CREDITAMOUNT", $amount ) wasn't revealing my intention much, and told my subclasses about the implementation decision I made and then factored it out into the base class. If I was confident of the other tests of the methods like addToAccount that callled setCreditAmount then I probably wouldn't add any more.

If I decided to make it protected as you have done I would have written a test to make sure the exception would be thrown in the appropriate context before I added the caller test:

{ package NotASubclass;
  use Test::Exception;
  throws_ok { Account->new-> setCreditAmount( 42 ) } qr/is_protected/;
}

[download]

because that's new code and new functionality and I would want to make sure it works.

(although personally I wouldn't have bothered adding the test since I find that adding this sort of thing doesn't seem to solve any problems... I also would use methodNamingThatHurtsMyEyes :-)

In reply to Re: How deep should unit tests go? by adrianh
in thread How deep should unit tests go? by gargle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.