Do you trust your user? If not then this article will give you some ideas about what can go wrong.

Also as I0 alluded to, the period in the character class is a little more...generous...than you think.

Perl on Win32 will accept "/" as a valid path delimiter.

You may or may not wish to pass this freedom along to your users.

Did you want to complicate the possibility that the current working directory is the home directory? If not then throw a ? after the first path delimiter.

Likewise it is generally a bad idea to assume you had a match and then accept $1. Test whether the match succeeded. Else mistakes will turn into the assumption that the home directory is the working directory, or else the output of a previous match will be accepted instead.

In reply to Re (tilly) 1: Regex Improvement by tilly
in thread Regex Improvement by Lexicon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.