There's a potential spam issue, because your error checking is poor. However, since you don't provide a sample template, I can't be sure.

Your code:

defined $from && $from =~ m/.+\@.+/
doesn't forbid a newline. If that newline is inserted into the header of the message, a spammer can create an arbitrary subject and sender, and then a blank line, permitting an arbitrary body. Sure, your added header and sender will be at the bottom of the message, but at that point, who cares?

Also, just being able to send a message to a recipient designated by a form field is considered very bad manners in this day and age. Please discontinue the promotion of your mailscript.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.


In reply to Re: CGI Contact Form / Mailer by merlyn
in thread CGI Contact Form / Mailer by vladb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.