Setting $/ to undef will ignore the end-of-line markers in the file, so @filecontents will be an array containing the entire file in one element. Your foreach loop has only one item to work on, and will exit after processing it.

Try correcting that—by leaving $/ at its default value, so @filecontents has one line per element.

added in update
rmexico's (belated) explanation of why s?he's setting $/ undef tends to make my suggestion rather pointless.

Since the entire contents of the file will be read into a scalar, tirwhan's solution to use a regex to get an array from the scalar is much closer to the OP's requirement.

emc

" When in doubt, use brute force." — Ken Thompson

In reply to Re: getting a regex to return an array of matches? by swampyankee
in thread getting a regex to return an array of matches? by rmexico

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.