I'm not 100% what you want your script to do, but I'm pretty sure that copy ($figfile, "$1.tmp") doesn't do what you want.

In my quick-and-dirty version of your script (with paths for my localhost), copy ($figfile, "$1.tmp") copies "your_file.htm" to a file named ".tmp", instead of one named "your_file.htm.tmp". Is the latter what you want?

Edit: I should probably explain why. $1 does the following (from perldoc.perl.org):

The text matched by the used group most-recently closed (i.e. the group with the rightmost closing parenthesis) of the last successful search pattern.
In your foreach block, $1 is undef. I'm not 100% sure why, so maybe some of the senior monks can answer that question.

Also, I'll mention that you never chdir to $html_dir in your code, so your copy happens in whichever directory your script is running (which I'm guessing isn't where you keep your HTML files).

Finally, it's helpful to include the error message that you're getting when you run your code.

Here's your code, properly formatted with <code> tags. Also, those line numbers in your code aren't helpful here. Format your code and your questions better if you want quicker answers. The details are here: Writeup Formatting Tips.

#!/pw/prod/svr4/perl/bin/perl -w # ARGUMENTS: engine_figurelinks.pl xx_manual_vvv # where xx = manual code, vvv = version # # MODIFICATIONS: # #------------------------------------------------------ use warnings; use diagnostics; use Env qw(SERVER_NAME); use CGI qw(:standard :netscape); use File::Copy; new CGI; #------------------------------------------------------ ($manualdir_param) = @ARGV; $working_dir = $manualdir_param; $working_dir =~ s/manualdir=//i; $data_area = "/tmp"; $html_dir = "$data_area/$working_dir"; #------------------------------------------------------ # Loop to locate HTML files and make working tmp copies opendir( HTMLSTORIES, "$html_dir") || die "HTML files do not exist: $1 +"; @FigureArray = grep{/\.htm$/} readdir ( HTMLSTORIES ); foreach $figfile (@FigureArray) { copy ($figfile, "$1.tmp") or die "Can not make temporary copy of f +ile: $1"; } closedir HTMLSTORIES;

----------
Using perl 5.8.1-RC3 unless otherwise noted. Apache/1.3.33 (Darwin) unless otherwise noted. Mac OS X 10.3.9 unless otherwise noted.

In reply to Re: Making tmp copies of files by alienhuman
in thread Making tmp copies of files by xdbd063

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.