if ($file_path =~ /defines|sccpch|sms81154|sms97767/)
    {
        next;
    }
    elsif(!($file_path =~ /defines|sccpch|sms81154|sms97767/))  # This
+ is redunant
    {
        if (open(FILES, $file_path))                            # use 
+the -f operator to test 
                                                                # file
+s existance, or -W to test  
                                                                # if i
+t can be written to
        {
            if (!($file_path =~ /\.lfa|\.zip|\.txt|UASTG/))
            {
                print (DATA "$file_path\n");
            }
        }
        else
        {
            die ("Could not open[$file_path], $!\n");
        }
## The above is redunant... it would be better stated as:


    if ($file_path =~ /defines|sccpch|sms81154|sms97767/)
    {
        next;
    }
    else
    {
        if (-f $file_path)
        {
            if (!($file_path =~ /\.lfa|\.zip|\.txt|UASTG/))
            {
                print (DATA "$file_path\n");
            }
        }
        else
        {
            die ("Could not open[$file_path], $!\n");
        }
    }

[download]

They say that time changes things, but you actually have to change them yourself.

—Andy Warhol

In reply to Re: Help with a faster loop by JediWizard
in thread Help with a faster loop by gzayzay

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.