ah. you were close -- you said with the use FileNamePrep qw(&func1); and use FileNamePrep qw(&func2); that you wanted func1 and func2 available, but you never actually called them ...
use FileNamePrep qw( func1 func2 ); ... print "Please enter the name of the file to copy.\n"; my $file1 = func1(); ... print "\nPlease enter the name of the copy destination.\n"; my $file2 = func2();
Update: Hmm.. also, i see that func1() and func2() are nearly identical, and also that neither returns anything, and they both localize, with 'my', $file1 and $file2, so really they don't do anything.. i think what you mean is something like this:
use FileNamePrep qw( promptFilename ); ... my $file1 = promptFilename("Please enter the name of the file to copy. +"); ... my $file2 = promptFilename("Please enter the name of the copy destinat +ion."); ######################### package FileNamePrep; use strict; use Exporter; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); $VERSION = 0.1; @ISA = qw(Exporter); @EXPORT = (); @EXPORT_OK = qw(promptFilename); %EXPORT_TAGS = ( DEFAULT => [qw(promptFilename)], Both => [qw(promptFilename)]); sub promptFilename { my $prompt = shift; print $prompt . "\n"; my $file; while(! $file ){ # fixed this loop $file = <>; chomp($file); $file =~ s/^"(.+)"$/$1/; # unquote } return $file; } 1;
Update: I assume this was a module excercise, but also be aware of the standard File::Copy module. Update: Fixed the bad loop in promptFilename -- thanks to runrig

In reply to Re: Making/Using a module. by davidrw
in thread Making/Using a module. by Andrew_Levenson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.