Which one of the below three examples would you prefer?

It depends :-)

sub sg {
  if (COND) {
    return 1;
  } else {
    return 2;
  }
}

[download]

I'd do this if both paths through the code were equally likely.

sub sg {
  if (COND) {
    return 1;
  } else {
    return 2;
  }
  die "should never reach this";
}

[download]

I'd never do this. I'd trust my test suite to catch any stupid code changes I might make rather than littering my code with die statements.

sub sg {
  if (COND) {
    return 1;
  }
  return 2;
}

[download]

I'd do this if 2 would be the "normal" result - although I'd probably write it as

sub sg {
  return 1 if COND;
  return 2;
}

[download]

As another option - if this was a method in some OO code I'd be looking to see whether that if statement was a sign that I was missing some polymorphic behaviour somewhere that I could factor out into separate methods.

In reply to Re: if else and not reachable coding style by adrianh
in thread if else and not reachable coding style by szabgab

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.