Update: davidrw's response above is much simpler. I was responding to the algorithm as posted, and pointing out that your inner loop needed some work :)
You should probably restructure your inner loop, and pull the
GenerateTestFileList() call outside of it.
my $count = 0;
foreach (@keywords) {
if( ($_ eq "database.txt") || ($_ eq "keywords_database.txt") ) {
print "Found $_\n";
$count++;
last if($count == 2);
}
}
if($count != 2) {
print "At least one database is missing.\n";
GenerateTestFileList();
}
I would also recommend using the string equality operator (eq) instead of regular expressions. You know exactly what the files are named, and you don't want an accidental match. For example, the strings "random_database.txt" and "some_other_database.txt.tar.gz" will match your
elsif(@keywords[$kdbase] =~ /database\.txt/) line above.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.