I think the way you are joining will work, but it will wait in sequential order, for each thread to join. That is it will wait to join $thr_{0} then on to $thr_{1}, etc. It dosn't take into account which thread finishes first. In the case where you are waiting for ALL threads to finish, it dosn't matter.

But there are cases where you want to detect which thread finishes first, then stop the others when that happens. You could also use a while loop to join each thread as they finish, if you were interested in the finish order, like: 

#!/usr/bin/perl
use warnings;
use strict;
use threads;
use threads::shared;
$| = 1;

my %threads;

foreach (1..10){
  share $threads{$_}{'die'};
  share $threads{$_}{'data'};
  $threads{$_}{'die'} = 0; 
  $threads{$_}{'data'} = 0; 
}

foreach (1..10) {
    $threads{$_}{'thread'} = threads->new('StartTest');
}

my @threads = (1..10);

while(1){
  foreach my $t (@threads){
        if($threads{$t}{'data'} > 5){
             $threads{$t}{'die'} = 1;
             $threads{$t}{'thread'}->join;
             @threads =  grep { $_ != $t } @threads;
    }
     }
if(scalar @threads == 0){last}
}

print "\n", "All threads done\n";
##########################################################

sub StartTest {
    my $self = threads->self;
    print "Thread ", $self->tid, " started\n";
    
    while(1){
    if( $threads{$_}{'die'} == 1){goto FINISH}
       else{ 
           print "From thread $self->",$threads{$_}{'data'}++,"\n";  
       sleep 1;
    };
    }
FINISH:    
    print "Thread ", $self->tid, " ending\n";
}

[download]
I'm not really a human, but I play one on earth. flash japh

In reply to Re: help on threads by zentara
in thread help on threads by tsk1979

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.