sub WriteSpinData { my ($OUT_FH, $ref_data) = @_; my ($last_major_frame, @cur_spin ); my $row_length = 15*160+1; for my $filename (sort keys %{ $ref_data }) { my ($basename) = basename $filename; for my $major ( sort { $a <=> $b } keys %{ $ref_data->{$filena +me} }) { ### Processing data for $basename [===| ] % done for my $minor (keys %{ $ref_data->{$filename}{$major} }) { next if $minor !~ /\d+/; my @data = @{ $ref_data->{$filename}{$major}{$minor} +}; if ( !@curspin ) { # This looks wonky ... you should double check thi +s # At the very least, the 165 should be in a consta +nt and # a comment should be here explaining why only $mi +nors that are # divisible by 10 are allowed to start a @curspin if (($data[3] == 165) and (($minor % 10) == 0) ) { my $index = "$filename,$major,$minor"; @cur_spin = ($index, @data[3..17]); } next; } push @cur_spin, @data[3..17]; if ( @cur_spin == $row_length ) { print $OUT_FH join(",", @cur_spin), "\n"; @cur_spin = (); } } $last_major_frame = $major; } print "$basename: " . int($last_major_frame) . " major frames. +\n"; } return; }

My criteria for good software:
  1. Does it work?
  2. Can someone else come in, make a change, and be reasonably certain no bugs were introduced?

In reply to Re: Refactoring nested if block by dragonchild
in thread Refactoring nested if block by bowei_99

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.