That's what arrays and loops are for!

my @c = split /,/, $hand; my $total = 0; # 2 cards for my $i1 (0..4) { for my $i2 ($i1+1..4) { $total += 2 if $c[$i1] + $c[$i2] == 15; } } # 3 cards for my $i1 (0..4) { for my $i2 ($i1+1..4) { for my $i3 ($i2+1..4) { $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] == 15; } } } ...

But we can do better.

my @c = split /,/, $hand; my $total = 0; for my $i1 (0..4) { for my $i2 ($i1+1..4) { $total += 2 if $c[$i1] + $c[$i2] == 15; for my $i3 ($i2+1..4) { $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] == 15; for my $i4 ($i3+1..4) { $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] + $c[$i +4] == 15; for my $i5 ($i4+1..4) { $total += 2 if $c[$i1] + $c[$i2] + $c[$i3] + $ +c[$i4] + $c[$i5] == 15; } } } } }

Let's go further:

my @c = split /,/, $hand; my $total = 0; our $sum; for my $i1 (0..4) { local $sum = $i1; for my $i2 ($i1+1..4) { local $sum = $sum + $c[$i2]]; $total += 2 if $sum == 15; for my $i3 ($i2+1..4) { local $sum = $sum + $c[$i3]; $total += 2 if $sum == 15; for my $i4 ($i3+1..4) { local $sum = $sum + $c[$i4]; $total += 2 if $sum == 15; for my $i5 ($i4+1..4) { local $sum = $sum + $c[$i5]; $total += 2 if $sum == 15; } } } } }

Let's add optimizations:

my @c = split /,/, $hand; my $total = 0; our $sum; for my $i1 (0..4) { local $sum = $i1; for my $i2 ($i1+1..4) { local $sum = $sum + $c[$i2]]; $total += 2 if $sum == 15; next if $sum >= 15; for my $i3 ($i2+1..4) { local $sum = $sum + $c[$i3]; $total += 2 if $sum == 15; next if $sum >= 15; for my $i4 ($i3+1..4) { local $sum = $sum + $c[$i4]; $total += 2 if $sum == 15; next if $sum >= 15; for my $i5 ($i4+1..4) { local $sum = $sum + $c[$i5]; $total += 2 if $sum == 15; } } } } }

While I eliminated a lot of redundancy both visually and in the number of checks, I'm sure there's still a better *algorithm*.


In reply to Re: calculating cribbage points by ikegami
in thread calculating cribbage points by dracos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.