Is the conditional known before the if-else logic? If so, why not just pass them as a precomputed argument rather than as a closure? 

sub alpha {
    my $self = shift;
    my $condition = 1; # always
    return $self->_internal_sub($condition);
}

sub beta {
    my $self = shift;
    my $gamma = get_gamma_somewhere();
    my $condition = $self->{baz} eq $gamma;
    return $self->_internal_sub($condition);
}
sub _internal_sub {
    my $self = shift;
    my $condition = shift;
    ...
    foreach ...
        if ...
            if ...
                if ...
                    push @foo, [ @bar ] if $condition;
                }
            }
        } else {
            push @foo, [ @bar ] if $condition;
        }
    }
    push @foo, [ @bar ] if $condition;
    return \@foo;
}

[download]

-xdg

Code written by xdg and posted on PerlMonks is public domain. It is provided as is with no warranties, express or implied, of any kind. Posted code may not have been tested. Use of posted code is at your own risk.

In reply to Re: Seek Help Refactoring by xdg
in thread Seek Help Refactoring by jkeenan1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.