You seem to have the structure:

if a and b and c then do...
if !a then do...

Which, if I'm not messing up my logic analysis, can be simplified to:

if !a or b and c then do...

Both functions should be simplified down to: 

sub alphabeta {
    my ($self, $test) = @_;
    ...
    foreach ...
        if (!... || ... && ...) {
            push @foo, [ @bar ] if !$test || $self->{baz} eq $gamma;
        }
    }
    push @foo, [ @bar ] if !$test || $self->{baz} eq $gamma;
    return \@foo;    
}

[download]
Then you'd just call it with the second value turned on if you wanted $self->{baz} tested.

I am of course also little confused as to what the second push @foo, [ @bar ] is there for.

In reply to Re: Seek Help Refactoring by TedPride
in thread Seek Help Refactoring by jkeenan1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.