I'm actually thinking that it IS safer to use SvPVX to get the buffer, so that I don't promote it 'by accident'.

I agree that using SvPVX in this context is better practice. If you haven't allocated memory for the string, SvPVX will attempt to dereference a struct member that isn't there, and segfault*. If you haven't both allocated memory and made the string POK, SvPV_nolen will return a buffer that's not writeable, and you'll get a segfault when you try to write to it*.

perlapi seems to suggest that SvPV_nolen is safer. That is not true for this usage, and putting it in there lends a false sense of security. Better to use SvPVX -- so it's clear that you're working without a net.

* If you're lucky. In general, Valgrind is extremely helpful for detecting these kinds of problems, and I strongly recommend it. Sadly, I don't think it will help in this specific case, because it's Linux-only (there's also a FreeBSD variant, but it doesn't seem to work with Perl).

--
Marvin Humphrey
Rectangular Research ― http://www.rectangular.com

In reply to Re^6: XS efficient copy (SvCUR_set) by creamygoodness
in thread XS efficient copy by TheDauthi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.