Hello everyone: I'm working on a script that will go through my apache httpd log directory and gzip and move log files older than 24 hours to an archive directory. Since I'm new to perl programming I was hoping others could offer advice on "best practices" or "best way to do it" on the perl code I've written so far. Here's my script so far: 
#!/usr/bin/perl -w
use strict;
use File::Copy;

my $log_dir = "/etc/httpd/logs/2006";
my $archive_dir = "/etc/httpd/logs/archive";

#open logs directory and get files older than 24 hours
opendir(LOGS, $log_dir) 
    or die "Directory could not be opened: $!";
my @files = grep { -M "$log_dir/$_" > 1 } readdir(LOGS);
closedir(LOGS)
    or die "Directory could not be closed: $!";

#check each file in logs directory
my @to_move;
foreach my $file (@files) {
    $file eq '.' || $file eq '..'
    or push @to_move, $file;
}

#perform file test; compress file; move file
foreach my $file (@to_move) {
    if (! -l $file)
    {
    chdir $log_dir
        or die "Can't chdir to $log_dir: $!";
    system "gzip $file";
    move "$file.gz", $archive_dir;
    } else {
    die "Can't move $file: $!";
    }
}

[download]

In reply to moving old files by pbaumgar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.