Thanks, this is what I've got so far,

At the moment all the source files are found, which is brilliant but they dumped into the destination directory and I'm losing the directory structure.

Im going to change the code to append the destination varible with the current directory when copy() fails.

Im going to try the reg ex in the morning.Something like this $\/* to match the / at the end of the string. Then happy days. 

#!/usr/local/bin/perl -W # force taint checks, and print warnings
use strict; # install all three strictures
use File::Copy;
use File::Find;


my $path = "";  #define full path to source folder
my $newpath = "";  #define  path to new folder
my @Filenames;


#recursively search  $path for files


opendir (ORIG , $path);
@Filenames = readdir ORIG;
closedir ORIG;


$|++; # force output of buffer
find (\&doCopy, $path); #Recursively search $path for files to copy

sub doCopy {
    return if ! -f $File::Find::name;
    chdir($path) || die "cannot move to $path";
    my $destFile = $newpath . $_;
    #print "\$destFile = $destFile\n";
    copy( "$_" , "$destFile" ) or  $path = $File::Find::dir   ;
    #print "$_ cannot be copied  $!. $File::Find::dir \n" ;

}

[download]

In reply to Re^2: Copying files between directories. How can I improve this code. by richill
in thread Copying files between directories. How can I improve this code. by richill

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.