You can just use the named captures $1 and $2 to store the values (also note the warning in
perlre about
(?{ code }) being highly experimental).. also, no need for string references here.
use strict;
use warnings;
while (<DATA>) {
next unless /\S/;
my ( $sunrise, $sunset ) = get_time($_);
next unless $sunrise && $sunset;
printf "Sunrise is: %s Sunset is: %s\n", $sunrise, $sunset;
}
sub get_time {
my $string = shift;
return unless $string =~ /sunrise:\s+(\d+:\d+)\s+sunset:\s+(\d+:\d+)
+/;
return ( $1, $2 );
}
__DATA__
Aberdeen, Scotland 57 9 N 2 9 W sunrise: 03:12 sunset: 21:08
Adelaide, Australia 34 55 S 138 36 E sunrise: 06:52 sunset: 16:41
But where the undef was coming from was a blank line in <DATA> ... so the match failed, so $sunrise/$sunset where undef. Just a quick check for a valid string/success on the match resolves it.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.