If $type is a variable that really needs to be available to your entire program, then you should put the declaration at the top of the file. However, in this case, I'd suggest that you consider passing it as an argument to your function:

sub print_summary { my ($type) = @_; if($type=~/w/) { print "hello\n"; } } # ... later ... print_summary("world");

Actually, what I'd probably do is more along these lines...

sub summary { my ($type) = @_; if($type=~/w/) { return "Hello, "; } elsif ($type =~ /h/) { return "world!\n"; } } # ... later ... print summary("world"); print summary("hello");

Notice here that the function returns the string to be printed, rather than printing it. This makes the function more reusable in the event that you need to send the results somewhere other than standard output, e.g., write them to a file, send them over a socket, or capture them to a string for subsequent processing.


Sanity? Oh, yeah, I've got all kinds of sanity. In fact, I've developed whole new kinds of sanity. Why, I've got so much sanity it's driving me crazy.

In reply to Re: Problem with function by jonadab
in thread Problem with function by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.