The map doesn't buy you much in terms of golf here, and he's also changing the target hash. I'd probably approach it something more like:
my @table_to_hash = (
[ "ConfigData", \%ConfigData ],
[ "DicomDestinations", \%DestinationData ]
);
for (@table_to_hash) {
my ($table, $hash) = @$_;
$Data->Sql("SELECT * FROM $table");
while ($Data->FetchRow ()) {
my %x = $Data->DataHash();
$hash->{ $x{ID} }{ $x{DataName} } = $x{DataValue};
}
}
Update: I see this is almost the same as Zaxo's post at Re: reuse worth it for small items?, but note that mine will maintain the order. I'm not sure it matters, but it could.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.