You need to calculate the average outside the foreach loop.

use warnings; use strict; # sub get_avr { # 'get' implies that the sub is returning a value? sub print_avr { my ( $cluster ) = @_ # open(IN, "$outputfile"); # Where does $outputfile come from? You should pass this value # to the subroutine instead of using globals. What happens when # you try to read from an invalid filehandle? open IN, '<', $outputfile or die "Cannot open '$outputfile' $!"; my %data; while ( <IN> ) { my ( $hour, $cpu ) = /(\d+):\d+\s+([\d.]+)/ or next; $data{ hour }{ total } += $cpu; $data{ hour }{ count }++; } close IN; for my $hour ( sort { $a <=> $b } keys %data ) { print "$cluster $hour:00 ", $data{ $hour }{ total } / $data{ $ +hour }{ count }, "\n"; }

In reply to Re: printing outside a for loop by jwkrahn
in thread printing outside a for loop by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.