You haven't defined $ligand anywhere (if you had warnings and strict turned on, perl would've complained about that), yet you use it as the hash key. I'm not sure how your hash ends up with more than a single pair in it!

I would rewrite the meat of your code as follows:

# @key_set and @val_set are my names for @A1 and @A2 # there is no need to shuffle them! my %pairs; my $size = 100; # from the user until (keys(%pairs) == $size) { my $key = $key_set[rand @key_set]; my $val = $val_set[rand @val_set]; $pairs{"$key-$val"} = 1; # or even just: # $pairs{$key_set[rand @key_set] . "-" . $val_set[rand @val_set]} = +1; } for (keys %pairs) { print "$_\n"; }
This seems to fulfill your goal.

Jeff japhy Pinyan, P.L., P.M., P.O.D, X.S.: Perl, regex, and perl hacker
How can we ever be the sold short or the cheated, we who for every service have long ago been overpaid? ~~ Meister Eckhart

In reply to Re: Filling hashes by japhy
in thread Filling hashes by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.