PerlGrrl,
There are many ways to make your code look more pristine. They almost always involve trade-offs. One example would be to hide all your regexes in a subroutine or an object. Either of those approaches could be separated further by having a master subroutine/method that called each 1 regex specific routine in sequence stopping at first match. This allows you to add new matches relatively easy.
while ( <$fh> ) {
my ($yr, $mon, $day) = parse_date($_);
next if ! defined $yr;
# ...
}
Additionally, you probably want to have a look at
Date::Manip's 'ParseDate',
Date::Calc's 'Parse_Date',
Date::Parse, and
Regexp::Common::time for ideas on improving or expanding your matching criteria (possibly as a replacement)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.