Well, one way to optimise it would be to add
last if ($pt ne "" && $pc eq "");
That will get you out of the loop once you've found
what you're looking for. (cue U2)
You also want to use eq instead of == if you're testing
for "". This code prints hello.
$ha = "hi";
if ($ha == "") { print "hello\n"; }
If doing numeric comparisons, strings with no digits are
equal to 0. So $ha equals 0 as does "". If you turn on
warnings this will be pointed out.
Now if no-one else has done your regex, I'll look at that
more closely.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.