Suggestions:
Provide more information with $! when open fails (you'll apreciate it when it happens).
open (LOGFILE, "< $logfile") or die ("Could not open $logfile: $!");
You're kind of care free when mixing $thiscust with record fields, hash keys and file handles. Maybe something more like this:
$thiscust = (split /\//, $fields[4])[1];
if ( ! $cust{$thiscust} ) {
print "customer $thiscust\n";
$cust{$thiscust} = $thiscust;
open (my $fh, ">> ${prefix}${thiscust}${suffix}")
or die ("Cannot open ${prefix}${thiscust}${suffix}: $!");
$cust{$thiscust} = $fh;
}
my $fh = $cust{$thiscust};
print $fh $_;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.