This sounds a little backwards to be as a good way to ease yourself into the team. I'd have been inclined to say someting about how many times strictures had saved me untold time and embarasement in the past and would it be ok to add them through out the code base - "I'll fix any problems that show up as I add them".

Same sort of thing with the poorly structured code - "I don't quite see what's going on here" (to the original author), then: "Oh, now I see, but would it be better like this? Is it ok if I make similar changes elsewhere to improve maintainability of the code?".

I'd watch out making cosmetic changes that only affect layout unless the original layout was inconsistent. There's nothing that stirs up wrath more than having someone come and "fix" your carefully laid out code! One thing that may help is running the code through a pretty printer - just to make the layout consistent of course. :)

DWIM is Perl's answer to Gödel

In reply to Re: Consideration for others code by GrandFather
in thread Consideration for others code by tcf03

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.