You are basically just manually doing a SQL JOIN in the code -- you can simplify this by letting the database (in this case i see it's postgres) do the work:
... # open file; connect to $dbh my $sth = $dbh->prepare(qq{ SELECT d1.d_id as did1, d2.d_id as did2, d1.c_id as cid1, d2.c_id as cid2 FROM d as d1, d as d2 WHERE d1.d_id = ? AND d2.d_id = ? AND d1.c_id != d2.c_id }); while(<INPUT>){ my( $did1, $did2, $score1, $score2 ) = split "\t", $_; next unless $score1 >=70 && $score2 >=60; $sth->execute($did1,$did2); while( my $row = $sth->fetchrow_arrayref ){ print join(', ', @$row), "\n"; } } close INPUT;

In reply to Re: Feedback Appreciated on text-parsing, SQL querying subroutine by davidrw
in thread Feedback Appreciated on text-parsing, SQL querying subroutine by Angharad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.