You can reduce the amount of work by restricting the file list to those which actually contain "Closed". Do that by replacing opendir . . . readdir . . . closedir with glob. You can also shorten your loop code a little by taking advantage of $_ and its properties.

#!/usr/bin/perl

use strict;
use warnings;

my $dir = 'C:\Tickets';

chdir $dir
    or die "Error - Please check that $dir exists and is accessible.\n
+";

my @fileList = glob '*Closed*';

foreach (@fileList) {
    next if -d;
    my $oldname = $_;
    s/Closed/Open/;
    rename $oldname, $_;
}

[download]

I also removed the big if..else by just dieing with the error message if chdir fails. That would avoid closedir on a bad handle in your code. Moving closedir inside the affirmative branch would do that, too.

Update: You can remove the dependence on chdir entirely by including $dir in the glob pattern. With the error handling for rename added, the new version looks like this, 

#!/usr/bin/perl

use strict;
use warnings;

my $dir = 'C:\Tickets\';

my @fileList = glob "${dir}*Closed*";

foreach (@fileList) {
    next if -d;
    my $oldname = $_;
    s/Closed/Open/;
    rename $oldname, $_  or
        $_ = $oldname,
        warn $_, ' not renamed: ', $!;
}

[download]

After Compline,
Zaxo

In reply to Re: Shorter/Better way to rename list of files in a directory by Zaxo
in thread Shorter/Better way to rename list of files in a directory by Scrat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.